Merged
Conversation
glbrntt
requested changes
Nov 6, 2024
Contributor
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Awesome! Thanks for doing this Rick, I left a couple of comments on small things to fix.
| /// Set `option` to `value` on this `Channel`. | ||
| /// - Parameters: | ||
| /// - option: The option to set. | ||
| /// - value: The new of the option. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// - value: The new of the option. | |
| /// - value: The value of the option. |
Sources/NIOCore/ByteBuffer-hex.swift
Outdated
| @@ -321,15 +321,15 @@ extension ByteBuffer { | |||
| /// Returns a hex dump of this `ByteBuffer` in a preferred `HexDumpFormat`. | |||
| /// | |||
| /// `hexDump` provides four formats: | |||
Contributor
There was a problem hiding this comment.
apropos of nothing, "four" appears to no longer be correct here.
| @preconcurrency | ||
| @inlinable | ||
| public func unwrap<NewValue: Sendable>( | ||
| orReplace replacement: NewValue |
Contributor
There was a problem hiding this comment.
I think the docs and code are clearer in terms of replacement here
| @inlinable | ||
| @preconcurrency | ||
| public func unwrap<NewValue>( | ||
| orElse callback: @escaping @Sendable () -> NewValue |
Contributor
There was a problem hiding this comment.
Same here, I think callback is clearer than orElse in the docs etc.
Motivation: Documentation checking catches more issues in Swift 6.0. Modifications: Adopt the Swift 6.0 image and fix the errors. Result: More accurate docs.
glbrntt
approved these changes
Nov 7, 2024
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 21, 2024
Documentation checking catches more issues in Swift 6.0. Adopt the Swift 6.0 image and fix the errors. More accurate docs. (cherry picked from commit adfd61a)
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 21, 2024
Documentation checking catches more issues in Swift 6.0. Adopt the Swift 6.0 image and fix the errors. More accurate docs. (cherry picked from commit adfd61a)
Lukasa
added a commit
that referenced
this pull request
Nov 22, 2024
Documentation checking catches more issues in Swift 6.0. Adopt the Swift 6.0 image and fix the errors. More accurate docs. (cherry picked from commit adfd61a) Co-authored-by: Rick Newton-Rogers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Documentation checking catches more issues in Swift 6.0.
Modifications:
Adopt the Swift 6.0 image and fix the errors.
Result:
More accurate docs.